Skip to content

Annotate Custom Brushes + Add New Custom Brushes#72

Open
maxmmitchell wants to merge 4 commits into
mainfrom
annotate-brushes
Open

Annotate Custom Brushes + Add New Custom Brushes#72
maxmmitchell wants to merge 4 commits into
mainfrom
annotate-brushes

Conversation

@maxmmitchell
Copy link
Copy Markdown
Contributor

@maxmmitchell maxmmitchell commented May 12, 2026

  • add new versions of custom brushes with annotations from the Ink team
  • add new custom brushes from the Ink team (jelly wobble, pressure wave, shading pencil)
  • add icons for new custom brushes
  • add new texture for pencil brush
  • change file extensions from .gz to .brushfamily to more accurately reflect data
  • fix texture for sixteenth note (was the same as treble clef)
  • move custom brush name strings to strings.xml

@maxmmitchell maxmmitchell marked this pull request as ready for review May 12, 2026 15:35
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three new custom brushes—Jelly Wobble, Pressure Wave, and Shading Pencil—along with their associated vector drawables and raw resources, and adds a pencil texture to the bitmap store. Review feedback recommends improving the formatting of the textureResources map for readability, externalizing hardcoded brush names to string resources for internationalization, and removing version suffixes from resource filenames to adhere to standard naming conventions.

Comment thread app/src/main/java/com/example/cahier/core/ui/CahierTextureBitmapStore.kt Outdated
Comment thread app/src/main/java/com/example/cahier/features/drawing/CustomBrushes.kt Outdated
Comment thread app/src/main/java/com/example/cahier/features/drawing/CustomBrushes.kt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant